Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

fix comparator for decreasing function of threshold skipping #888

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

nlpng
Copy link
Contributor

@nlpng nlpng commented Mar 3, 2020

What this patch does to fix the issue.

Fix the comparator condition in apply_thresholds.cpp for threshold skipping.
For decreasing case like this (58,-76,-211, -1), where the ts0 is 58, ts1 is -76, and ts2 is -211

Link to any relevant issues or pull requests.

#247

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 3, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlpng Oh, thanks.
Ownership Approval

@iizukak iizukak requested a review from tsawada March 3, 2020 06:10
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@iizukak
Copy link
Member

iizukak commented Mar 4, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 4, 2020

⏳Merge job is queued...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants