This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
fix comparator for decreasing function of threshold skipping #888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this patch does to fix the issue.
Fix the comparator condition in
apply_thresholds.cpp
for threshold skipping.For decreasing case like this
(58,-76,-211, -1)
, where thets0
is 58,ts1
is -76, andts2
is -211Link to any relevant issues or pull requests.
#247