Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Include types.h instead of global.h #891

Merged
merged 4 commits into from
Mar 12, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

types.h is jinja2 template free header.
and some includes are removed.

Link to any relevant issues or pull requests.

@primenumber primenumber requested a review from tkng March 4, 2020 01:38
@primenumber primenumber self-assigned this Mar 4, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 4, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak iizukak self-requested a review March 10, 2020 13:21
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 12, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit f77b0da into blue-oil:master Mar 12, 2020
@primenumber primenumber deleted the use-types-h branch March 24, 2020 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants