Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Update DLK -> Converter docs #896

Merged
merged 14 commits into from
Mar 10, 2020
Merged

Update DLK -> Converter docs #896

merged 14 commits into from
Mar 10, 2020

Conversation

Joeper214
Copy link
Contributor

What this patch does to fix the issue.

  • Remove DLK strings, contents and installation

Link to any relevant issues or pull requests.

n/a

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 5, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@Joeper214 Joeper214 changed the title Update DLK -> Converter docs [WIP] Update DLK -> Converter docs Mar 5, 2020
@Joeper214 Joeper214 changed the title [WIP] Update DLK -> Converter docs Update DLK -> Converter docs Mar 5, 2020
@Joeper214 Joeper214 self-assigned this Mar 5, 2020
kchygoe
kchygoe suggested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converter.* => blueoil.converter.*

iizukak
iizukak reviewed Mar 6, 2020
View reviewed changes
primenumber
primenumber suggested changes Mar 6, 2020
View reviewed changes
kchygoe
kchygoe approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iizukak
iizukak approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@iizukak
Copy link
Member

iizukak commented Mar 9, 2020

@primenumber Please check your commented issue.

@Joeper214 Joeper214 mentioned this pull request Mar 9, 2020
Merged
primenumber
primenumber approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@primenumber
Copy link
Contributor

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 10, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 10, 2020

😥Status check failed. Please fix problems and send /ready again.

@Joeper214 Joeper214 added the CI: test-all Run all tests once label Mar 10, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Mar 10, 2020
@Joeper214
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 10, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 10, 2020

😥Not mergeable. Please fix problems and send /ready again.

@Joeper214
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 10, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit b9beb28 into blue-oil:master Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@primenumber primenumber primenumber approved these changes

@kchygoe kchygoe kchygoe approved these changes

Assignees

@Joeper214 Joeper214

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joeper214 @iizukak @primenumber @kchygoe