Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix condition for threshold-skipping #919

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

Quantized convolution output is used both non-quantizer and quantizer operations, optimizer optimize network wrongly.
pseudo code:

a = qconv(in, w)
b = quantize(a)
c = avgpool(a)

optimizer modify network to:

b = qconv_with_threshold_skipping(in, w)
c = avgpool(b) # Error!

This PR fix optimizer to stop apply threshold skipping if qconv or following operations until quantizer has multiple output operations.

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 13, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber requested a review from iizukak March 13, 2020 07:08
@primenumber primenumber self-assigned this Mar 13, 2020
@primenumber primenumber added the bug Something isn't working label Mar 13, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Apr 3, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 3, 2020

⏳Merge job is queued...

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 3, 2020

😥This PR is not approved yet.

@iizukak iizukak requested a review from tsawada April 3, 2020 01:19
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 3, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 602af65 into blue-oil:master Apr 3, 2020
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Apr 8, 2020
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants