Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add make commands #922

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Add make commands #922

merged 2 commits into from
Mar 17, 2020

Conversation

kchygoe
Copy link
Member

@kchygoe kchygoe commented Mar 13, 2020

  • install
  • install-gpu

What this patch does to fix the issue.

To develop on local env

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 13, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@kchygoe kchygoe requested a review from iizukak March 13, 2020 11:50
iizukak
iizukak approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@kchygoe kchygoe assigned tfujiwar and kchygoe and unassigned tfujiwar Mar 16, 2020
@kchygoe kchygoe requested a review from tfujiwar March 16, 2020 03:02
tfujiwar
tfujiwar reviewed Mar 16, 2020
View reviewed changes
Makefile
Comment on lines +23 to +25
.PHONY: lint
lint:
flake8 ./blueoil --exclude=templates,converter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't test-blueoil-pep8 enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st, this is for development.
2nd, for flake8, using docker sounds too complecated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@kchygoe kchygoe requested a review from tfujiwar March 17, 2020 04:33
tfujiwar
tfujiwar approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kchygoe
Copy link
Member Author

kchygoe commented Mar 17, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 17, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 4c5014a into blue-oil:master Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees

@kchygoe kchygoe

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchygoe @iizukak @tfujiwar