Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Add time measurement flag to all elf binaries in Makefile #928

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

tk26eng
Copy link
Contributor

@tk26eng tk26eng commented Mar 17, 2020

What this patch does to fix the issue.

This patch makes code simpler.

Link to any relevant issues or pull requests.

#924

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 17, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tk26eng tk26eng requested review from iizukak and tsawada March 18, 2020 05:24
@tk26eng tk26eng self-assigned this Mar 18, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@iizukak
Copy link
Member

iizukak commented Mar 18, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 18, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit f0c4b32 into blue-oil:master Mar 18, 2020
@tk26eng tk26eng deleted the add_time_flag branch March 18, 2020 09:12
@tk26eng
Copy link
Contributor Author

tk26eng commented Mar 18, 2020

Fix #924

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants