Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix run.py time measurement log output #930

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

kchygoe
Copy link
Member

@kchygoe kchygoe commented Mar 17, 2020

which has been devided twice.

What this patch does to fix the issue.

log output about time measurement is wrong

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 17, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@kchygoe kchygoe self-assigned this Mar 17, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@kchygoe kchygoe requested a review from tsawada March 18, 2020 01:31
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

Won't this confuse people? After this change, the log message look exactly the same but has different meaning.

@kchygoe
Copy link
Member Author

kchygoe commented Mar 18, 2020

ya, it would be better to change function name and variables later

@kchygoe
Copy link
Member Author

kchygoe commented Mar 18, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 18, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit ae82305 into blue-oil:master Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants