Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Improve readability of the predict script #942

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Improve readability of the predict script #942

merged 2 commits into from
Mar 27, 2020

Conversation

tfujiwar
Copy link
Contributor

What this patch does to fix the issue.

This script was reviewed by a readability reviewer before but was not fixed yet.
#838 (review)

Link to any relevant issues or pull requests.

Closes #868 .

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 25, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tfujiwar tfujiwar requested a review from iizukak March 25, 2020 02:11
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@tfujiwar tfujiwar requested a review from tsawada March 25, 2020 06:51
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@tfujiwar
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 27, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit f5cb4b4 into blue-oil:master Mar 27, 2020
@tfujiwar tfujiwar deleted the improve-predict-script branch March 27, 2020 03:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve readability of blueoil/cmd/predict.py
3 participants