Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix comment typo in __init__.py in blueoil/blueoil/quantizations #944

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix comment typo in __init__.py in blueoil/blueoil/quantizations #944

merged 1 commit into from
Mar 26, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Mar 25, 2020

What this patch does to fix the issue.

Fix comment typo

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 25, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@oatawa1 oatawa1 requested a review from iizukak March 25, 2020 05:04
@oatawa1 oatawa1 self-assigned this Mar 25, 2020
iizukak
iizukak approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@oatawa1 oatawa1 requested a review from tsawada March 25, 2020 06:58
@oatawa1
Copy link
Contributor Author

oatawa1 commented Mar 25, 2020

@iizukak Thank you.

tsawada
tsawada approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@oatawa1
Copy link
Contributor Author

oatawa1 commented Mar 26, 2020

@tsawada Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Mar 26, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 26, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 398b10c into blue-oil:master Mar 26, 2020
@oatawa1 oatawa1 deleted the fix-typo branch March 26, 2020 02:12
@tsawada
Copy link
Contributor

tsawada commented Mar 26, 2020

Didn't notice a typo in the commit message 😭

@oatawa1 oatawa1 changed the title Fix comment typo in __inin__.py in blueoil/blueoil/quantizations Fix comment typo in __init__.py in blueoil/blueoil/quantizations Mar 26, 2020
@oatawa1
Copy link
Contributor Author

oatawa1 commented Mar 26, 2020

@tsawada 😭 I'm sorry. What should I do?

@tsawada
Copy link
Contributor

tsawada commented Mar 26, 2020

Nothing. Just forget about it 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tsawada tsawada tsawada approved these changes

Assignees

@oatawa1 oatawa1

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oatawa1 @tsawada @iizukak