Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

How to quantize document #955

Merged
merged 12 commits into from
Apr 13, 2020
Merged

How to quantize document #955

merged 12 commits into from
Apr 13, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Mar 27, 2020 •
edited
Loading

What this patch does to fix the issue.

Create a quantize document
Require #954 to make equation render correctly

Link to any relevant issues or pull requests.

Close #931

TO DO

Overall

  • How to quantize the Weight
  • How to quantize the Activation
  • How to use TensorFlow's custom getter and variable_scope to quantize
  • Write simple sample code in your documentation.
  • Insert in to index

Ops

  • BinaryChannelWiseMeanScalingQuantizer
  • BinaryMeanScalingQuantizer
  • LinearMidTreadHalfQuantizer

@oatawa1 oatawa1 self-assigned this Mar 27, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 27, 2020
iizukak
iizukak reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oatawa1
Thank you!!

  1. Quantizer is not converter only stuff. How about to create new section Quantize.
  2. Please check your equations can be show correctly on the preview.

https://deploy-preview-955--blueoil.netlify.com/converter/quantize.html

@oatawa1 oatawa1 force-pushed the documentation-how-to-quantize branch from c466ff1 to 0704c07 Compare March 31, 2020 08:47
@oatawa1 oatawa1 force-pushed the documentation-how-to-quantize branch 2 times, most recently from 24be7d6 to 8ca7baf Compare March 31, 2020 09:34
@oatawa1 oatawa1 force-pushed the documentation-how-to-quantize branch from bba7949 to d345dac Compare April 1, 2020 07:36
@oatawa1 oatawa1 marked this pull request as ready for review April 2, 2020 08:35
@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 2, 2020 •
edited
Loading

@iizukak
Thanks, I moved to the new section and now eq. is rendered correctly.

I changed this PR to ready to review. Could you review this?

iizukak
iizukak reviewed Apr 2, 2020
View reviewed changes
docs/quantize/quantize_example.py Outdated
@@ -0,0 +1,104 @@
from functools import partial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, Sorry, This file may should put under the blueoil/networks/ directory.
And it's good to separate to 2 PRs.

  1. Example code PR.
  2. Documentation PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. will be in Add a simple network as a supplementary source code for how to quantize document. #966

@oatawa1
Fix parameter typo quantize_last_conv in activation_quantization.rst
dd52dbb 
Add base FooNetwork to Example code (This will be moved out later)
@oatawa1 oatawa1 mentioned this pull request Apr 3, 2020
Merged
@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 3, 2020

@iizukak Thanks for the review.

Currently, I'll keep quantize_example.py in this PR until #966 merge.

@iizukak
Copy link
Member

iizukak commented Apr 9, 2020

@oatawa1
I want quantized graph structure.
How about to add netron image of sample network?

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 10, 2020

@iizukak Thank you for the suggestion, I added the graph structure image.

@iizukak
Copy link
Member

iizukak commented Apr 13, 2020

@oatawa1 Can you remote WIP now?

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 13, 2020

@iizukak I'm sorry I don't understand what you mean?

I'm working on this PR now and test on the server.

@iizukak
Copy link
Member

iizukak commented Apr 13, 2020

@oatawa1
About PR title.
WIP means "not ready for merge".
Is this PR ready for merge?

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 13, 2020 •
edited
Loading

@iizukak Understood.
This PR is not ready to merge. Some revision are required due to the change of example network.

I will notify you again when this PR is ready.

@iizukak
Copy link
Member

iizukak commented Apr 13, 2020

@oatawa1 I see 😄

@oatawa1 oatawa1 changed the title [WIP] How to quantize document How to quantize document Apr 13, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 13, 2020

@iizukak I removed [WIP] from the title. Please review this PR again.

@oatawa1 oatawa1 requested a review from iizukak April 13, 2020 05:08
iizukak
iizukak approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 13, 2020

@iizukak Thanks.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 13, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 13, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 090781e into blue-oil:master Apr 13, 2020
@oatawa1 oatawa1 deleted the documentation-how-to-quantize branch April 13, 2020 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

Assignees

@oatawa1 oatawa1

Labels
CI: auto-run Run CI automatically documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: How to quantize
2 participants
@oatawa1 @iizukak