Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Set yaml default Loader #958

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Set yaml default Loader #958

merged 3 commits into from
Mar 31, 2020

Conversation

Joeper214
Copy link
Contributor

What this patch does to fix the issue.

Fix deprecated function for yaml.Loader

Link to any relevant issues or pull requests.

fixes #939

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 30, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@Joeper214 Joeper214 requested review from kchygoe and iizukak March 30, 2020 08:18
kchygoe
kchygoe approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

iizukak
iizukak approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@Joeper214 Joeper214 requested a review from tfujiwar March 31, 2020 01:39
tfujiwar
tfujiwar approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA
Thank you!!

@Joeper214
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 31, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 562dee9 into blue-oil:master Mar 31, 2020
@Joeper214 Joeper214 deleted the fix_yaml branch March 31, 2020 03:39
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Mar 31, 2020
@Joeper214 @oatawa1
Set yaml default Loader (blue-oil#958)
7dc9f4f
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Mar 31, 2020
@Joeper214 @oatawa1
Set yaml default Loader (blue-oil#958)
bdf8725
@tfujiwar tfujiwar mentioned this pull request Apr 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@kchygoe kchygoe kchygoe approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yaml.load() args are deprecated
4 participants
@Joeper214 @iizukak @kchygoe @tfujiwar