This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Remove metrics placeholder from training loop #959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this patch does to fix the issue.
In train.py,
metrics_summary_op
is an operator which takesmetrics_values
as a placeholder.metrics_values
comes fromsess.run(list(metrics_ops_dict.values()))
.This logic exists because we calculated metrics outside networks before. But now metrics calculation is a part of graphs. Essentially, we can execute
metrics_summary_op
directly without any placeholders.Link to any relevant issues or pull requests.
A part of #481 .