Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove metrics placeholder from training loop #959

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Remove metrics placeholder from training loop #959

merged 4 commits into from
Mar 31, 2020

Conversation

tfujiwar
Copy link
Contributor

What this patch does to fix the issue.

In train.py, metrics_summary_op is an operator which takes metrics_values as a placeholder. metrics_values comes from sess.run(list(metrics_ops_dict.values())).

metrics_values = sess.run(list(metrics_ops_dict.values()))
metrics_feed_dict = {placeholder: value for placeholder, value in zip(metrics_placeholders, metrics_values)}	

metrics_summary, = sess.run(	
    [metrics_summary_op], feed_dict=metrics_feed_dict,	
)

This logic exists because we calculated metrics outside networks before. But now metrics calculation is a part of graphs. Essentially, we can execute metrics_summary_op directly without any placeholders.

Link to any relevant issues or pull requests.

A part of #481 .

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 31, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfujiwar nice refactoring.
Ownership Approval

@tfujiwar
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Mar 31, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 5aeb663 into blue-oil:master Mar 31, 2020
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Mar 31, 2020
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants