Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Rollback Sphinx version to 2.4.4 #969

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Apr 8, 2020

What this patch does to fix the issue.

There is no fix version of Sphinx, thus it always keeps updated to the latest version, or keeps using the currently installed version in the environment.

Now Sphinx==3.0.0 is just released and contains some bug which leads to document generation errors.

So I fix the Sphinx version to the latest useable 2.4.4.

Link to any relevant issues or pull requests.

Closes #968

Other people got this issue as well.
sphinx-doc/sphinx#7429

@oatawa1 oatawa1 requested a review from iizukak April 8, 2020 03:04
@oatawa1 oatawa1 self-assigned this Apr 8, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Apr 8, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@oatawa1 oatawa1 changed the title Rollback the Sphinx version to 2.4.4 Rollback Sphinx version to 2.4.4 Apr 8, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak
Copy link
Member

iizukak commented Apr 8, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 8, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 32d91e6 into blue-oil:master Apr 8, 2020
@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 8, 2020

@iizukak Thank you, the document is working now. 🎉

@oatawa1 oatawa1 deleted the fix-doc-format branch April 8, 2020 03:34
oatawa1 added a commit to oatawa1/blueoil that referenced this pull request Apr 8, 2020
oatawa1 added a commit to oatawa1/blueoil that referenced this pull request Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blueoil documentation is broken
2 participants