Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove SSDRandomCrop augmentation from classification task tutorial. #978

Merged

Conversation

oatawa1
Copy link
Contributor

@oatawa1 oatawa1 commented Apr 13, 2020

What this patch does to fix the issue.

SSDRandomCrop augmentation is not compatible with classification task, thus I removed it out of the tutorial.

Link to any relevant issues or pull requests.

Closes #904

@oatawa1 oatawa1 requested a review from iizukak April 13, 2020 07:47
@oatawa1 oatawa1 self-assigned this Apr 13, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Apr 13, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 13, 2020

@iizukak Thanks

@oatawa1 oatawa1 requested a review from tfujiwar April 13, 2020 23:46
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 14, 2020

@tfujiwar Thank you.

@oatawa1
Copy link
Contributor Author

oatawa1 commented Apr 14, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 14, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit da10cc8 into blue-oil:master Apr 14, 2020
@oatawa1 oatawa1 deleted the remove-ssdrandomcrop-from-classification branch April 14, 2020 02:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSDRandomCrop augmentation option is not working in classification tutorial.
3 participants