added code for Refactor kubernetes matadata generator to support adding metadata across resources #4
Conversation
|
|
||
| ==== Breaking changes | ||
|
|
||
| *Affecting all Beats* | ||
|
|
||
| - Update to Golang 1.12.1. {pull}11330[11330] |
There was a problem hiding this comment.
You are not pulling in all these changes, are you?
This file may be auto-generated. I'm not sure.
In any case if you update it then it should just have the changes that you made.
| @@ -0,0 +1,211 @@ | |||
| // Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
Interesting. This adds node auto discovery.
While this might be interesting and useful to have in our 6.6 based version is it truly needed for supporting namespace labels?
There was a problem hiding this comment.
Yes, According to PR on Elastic/Beat regarding on this issue.
They have made this all required changes in each respected files.
I am following this:
elastic#13873
elastic#15528
There was a problem hiding this comment.
OK, then that is what we have to do.
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package kubernetes |
There was a problem hiding this comment.
Same concern as in comment on node.go
|
Wow, are all these changes required to back port the namespace label functionality to our 6.6-forked branch? |
|
Not a suitable solution! |
Added and changed code in respected file to get additional kubernetes metadata in metricbeat.