Fix issue with gallery in Android for flutter version 1.20 and up #304 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
requested changes
Nov 15, 2020
There was a problem hiding this comment.
So you are basically undoing #326 that fixed the problem according to lots of people (me included).
Any explanations on that?
Comment on lines
+32
to
43
| final hitCornersX = this.hitCornersX(); | ||
|
|
||
| if (hitCornersX.hasHitAny && move != Offset.zero) { | ||
| if (hitCornersX.hasHitBoth) { | ||
| return false; | ||
| } | ||
| if (hitCornersX.hasHitMax) { | ||
| return move.dx < 0; | ||
| } | ||
| return move.dx > 0; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Can you explain why bring this code back? This is the root of the problem on double taps. If the offset is zero in two axis it will return true anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the issue of an unresponsive gallery in
Android 11after updatingflutter to 1.20. I was unable to slide between images with left or right swipe actions. On investigating more and applying the changes submitted in this PR I was able to have it working again. This PR should also fix the issue reported in #304