Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double tapping in gallery #439

Closed
wants to merge 3 commits into from
Closed

fix double tapping in gallery #439

wants to merge 3 commits into from

Conversation

clragon
Copy link

@clragon clragon commented Jul 4, 2021

This MR attempts to fix #216

Using the Code provided by @deckerst migrated to null safety.

I have adjusted the touch slope factor for panning and it seems to work decently.

@clragon clragon marked this pull request as draft July 4, 2021 23:26
@clragon clragon marked this pull request as ready for review July 5, 2021 00:12
@clragon clragon closed this Jul 16, 2021
@ZahraVe
Copy link

ZahraVe commented Aug 3, 2021

I still have tapping issue on samsung phons (android 10). Could you please help me to fix the issue?
I am using ;
photo_view: ^0.12.0
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.2.3 20D91 darwin-arm, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 4.1)
[✓] Connected device (1 available)

@clragon
Copy link
Author

clragon commented Aug 5, 2021

@ZahraVe I cannot help you fix this,
this PR has it's own issues.

@renancaraujo said there might be a rewrite in the future
and that might fix double tapping.

For now there is no solution to this.

@ZahraVe
Copy link

ZahraVe commented Aug 12, 2021

@clragon Thanks for your response.

I have directly messaged @renancaraujo as he said 'if someone finds an issue in this matter after updating to 0.10.3, feel free to retake the discussion or message me on discord and I will attack this asap.' in #293 (comment) . Still waiting for any answer if they really work on this issue and if there is any hope to see it is fixed in near future.

Is there any alternative way of implementing or any other plugin that I can use instead ?

@clragon
Copy link
Author

clragon commented Aug 12, 2021

@ZahraVe you seem to have not understood my message.

There is currently no fix for the double tap issue.
It is not fixed in any released version.

issue #293 is not related to the double tap issue.
the issue you are looking for is #216.

@ZahraVe
Copy link

ZahraVe commented Aug 12, 2021

@clragon Seems I am a bit confiused among all gesture issues related to this plugin. But I got your point. Thanks anyway. so I need to have a look at other options. What is the alternative for this plugin in your opinion? thanks for youe help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] in gallery, tap is always panning when zoomed
2 participants