Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp: support Extended Metadata Frames (#4006) (#4014) #4018

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 4, 2024

Fixes #4006
Fixes #4014

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 84.46602% with 32 lines in your changes missing coverage. Please review.

Project coverage is 56.04%. Comparing base (82409e2) to head (1138a21).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/rtmp/amf0/data.go 87.50% 14 Missing and 6 partials ⚠️
...ternal/protocols/rtmp/message/extended_metadata.go 74.35% 6 Missing and 4 partials ⚠️
...ls/rtmp/message/extended_mpeg2ts_sequence_start.go 0.00% 1 Missing ⚠️
...al/protocols/rtmp/message/extended_sequence_end.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4018      +/-   ##
==========================================
+ Coverage   55.95%   56.04%   +0.09%     
==========================================
  Files         194      193       -1     
  Lines       19652    19693      +41     
==========================================
+ Hits        10996    11037      +41     
+ Misses       7815     7810       -5     
- Partials      841      846       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 770d72b into main Dec 4, 2024
8 checks passed
@aler9 aler9 deleted the fix/rtmp branch December 4, 2024 22:29
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This issue is mentioned in release v1.11.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant