Support proxying moderation through to appview #1233
Conversation
| try { | ||
| await transact | ||
| } catch (err) { | ||
| req.log.error( |
There was a problem hiding this comment.
what's the recovery from this?
now redsky will show that something is taken down but that isn't reflected on the PDS, right?
this is probably rare, but we should have a plan in mind for how to deal with it 🤔
would it make sense to fire of a reversal if the txn fails on the PDS? to attempt to keep state in sync? (of course that request can fail as well 😅
There was a problem hiding this comment.
It's a good question. I was imagining we'd monitor these errors closely and handle them in a high-touch way. My hunch is that if this happens it's probably not a temporary issue, and something needs fixing.
| await sc.createAccount('carol', users.carol) | ||
| await sc.createAccount('dan', users.dan) | ||
| export default async (sc: SeedClient, invite?: { code: string }) => { | ||
| await sc.createAccount('alice', { ...users.alice, inviteCode: invite?.code }) |
There was a problem hiding this comment.
code looks good - i'm a bit nervous about half-applied actions
Ideally we don't get into a bad state, but that might be unrealistic & I don't want to overengineer this just for this transition period.
I think at the least we need a good story about how the client will be notified of something going haywire & how we can recover from that state 🤔
I supposed one option would just be to somewhat rigorously monitor that error log so that we can manually patch it up if it fails (should basically never happen)
* in-progress work on proxying moderation to appview * tidy * proxy reports pds to appview, misc tidy * test proxying of moderation endpoints * remove report action fkeys from pds for appview sync * test appview/pds moderation synchronization * tidy * tidy * fix admin proxy tests, build * temp disable migration * rm relative @atproto/api imports * fix a couple more relative imports * tidy * reenable migration, comment contents temporarily * fully enable migration, remove build, misc test fixes --------- Co-authored-by: dholms <[email protected]>
* in-progress work on proxying moderation to appview * tidy * proxy reports pds to appview, misc tidy * test proxying of moderation endpoints * remove report action fkeys from pds for appview sync * test appview/pds moderation synchronization * tidy * tidy * fix admin proxy tests, build * temp disable migration * rm relative @atproto/api imports * fix a couple more relative imports * tidy * reenable migration, comment contents temporarily * fully enable migration, remove build, misc test fixes --------- Co-authored-by: dholms <[email protected]>
This adds support to the PDS for proxying moderation reports and actions to an appview.