RFC: Enable aspect ratio for external links #3506
Open
+193
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a followup from bluesky-social/social-app#7680
Request
In order to polish the feed for external links, allow the client to display the image in the correct aspect ratio
To stay consistent I have based myself off of this PR for adding this support for images. If I understood correctly this needs to be merged before I can then make a PR in the
social-appthat will resolve this aspect ratio from the thumbnail (something likeconst {path, mime, height, width} = resolvedLink.thumb.source)