Always highlight mentions in composer #7705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On web, the composer only highlights mentions if they have been inserted by selecting one of the suggestions in the autocomplete dropdown. Mentions typed manually are not highlighted.
This PR reworks the autocomplete TipTap extension so it just adds text rather than creating an editor node with special styling. The highlighting is then left to the new FacetDecorator, which combines the previous LinkDecorator and TagDecorator and adds support for mentions also. Instead of duplicating the detection logic in @atproto/api, it just uses the facet detection RichText. This ensures that the highlighting code in the editor is identical to the actual facet detection used when creating the post.
This issue was originally reported in a comment on another composer-related PR: #7562 (comment).