[Instrumentation] Signin #7742
Merged
[Instrumentation] Signin #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haileyok
approved these changes
Feb 14, 2025
Comment on lines
+112
to
+113
| const onAttemptFailed = () => { | ||
| failedAttemptCountRef.current += 1 |
There was a problem hiding this comment.
any reason to not use state here? just curious
There was a problem hiding this comment.
no not particularly, I just thought non-render-affecting stuff sounded ref-y
arcalinea
temporarily deployed
to
samuel/instrument-login - social-app PR #7742
Render
Destroyed
estrattonbailey
added a commit
that referenced
this pull request
Feb 17, 2025
* origin/main: Make Android app start faster by disabling JS bundle compression (#7751) Nightly source-language update Update tests Screen for searching user's posts (#7622) Add translations missed in last PR (#7748) 1.98 release: Pull latest from crowdin (#7746) [Instrumentation] Signin (#7742) Reenable router events (#7735) Nightly source-language update Bitdrift integration (#7728) Use effective filtering for feeds (#7736) Update PostInteractionSettingsDialog.tsx (#7726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following new events
signin:hostingProviderPressedsignin:hostingProviderFailedResolutionsignin:successsignin:backPressedsignin:forgotPasswordPressedsignin:passwordResetsignin:passwordResetSuccesssignin:passwordResetFailureTest plan
Filter console logs for
signin:, observe the logs happening. Check they look correct.