Add save load #36
Merged
Add save load #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsouter please could you rebase on main? |
jsouter
force-pushed
the
add_save_load_rb
branch
from
eb39986 to
4030c07
Compare
Having some issues with this, have spoken to Ollie and he's happy for me to lose a lot of the git history and add all the device save loader logic in one or two commits on top of main with him as a co-author (if you're happy with that too), will let you know once I can fix the tests. |
|
That sounds good thanks |
jsouter
force-pushed
the
add_save_load_rb
branch
5 times, most recently
from
96581a8 to
9dbd37a
Compare
* Make SignalRW Locatable * Add get_setpoint to signal backends Co-authored-by: Oliver Silvester <[email protected]>
jsouter
force-pushed
the
add_save_load_rb
branch
from
9dbd37a to
324ccf4
Compare
Co-authored-by: Oliver Silvester <[email protected]>
jsouter
force-pushed
the
add_save_load_rb
branch
2 times, most recently
from
919755c to
8e00b8c
Compare
Co-authored-by: Oliver Silvester <[email protected]>
jsouter
force-pushed
the
add_save_load_rb
branch
from
8e00b8c to
497ea1b
Compare
jsouter
force-pushed
the
add_save_load_rb
branch
from
bc42faa to
42220d6
Compare
Co-authored-by: Oliver Silvester <[email protected]>
|
Okay, that's everything as far as I can tell, should be ready to merge/review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #27 #31 #18, but now targeted on main