Reset completed iterations counter to 0 once target iterations are reached and detector is disarmed #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ached and detector is disarmed
ZohebShaikh
approved these changes
Sep 20, 2024
tomtrafford
pushed a commit
that referenced
this pull request
Oct 8, 2024
…ached and detector is disarmed (#590) * Reset completed iterations counter to 0 once target iterations are reached and detector is disarmed * Fix tests * Add test for double kickoff to increase coverage * Make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, if you run a plan from an ipython session without re-instantiating the ophyd device, you will only ever be able to fly it once currently, getting the error about kicking off more than the number of iterations.