Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some small issues discovered in testing #646

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

coretl
Copy link
Collaborator

@coretl coretl commented Nov 12, 2024

  • Raise NotConnected errors in mock mode too when failing on creation of mock signal because of invalid datatype
  • Support bare np.ndarray in SoftSignalBackend
  • Support tagged and variant unions for NTNDArray
  • Check that Devices have unique names in ensure_connected

WIP
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Looks good and only involved some minor changes to dodal (DiamondLightSource/dodal#899)

@coretl coretl merged commit f0d9565 into main Nov 13, 2024
9 checks passed
@coretl coretl deleted the soft-signal-typing branch November 13, 2024 14:19
ZohebShaikh pushed a commit that referenced this pull request Nov 14, 2024
- Raise `NotConnected` errors in mock mode too when failing on creation of mock signal because of invalid datatype
- Support bare `np.ndarray` in SoftSignalBackend
- Support tagged and variant unions for NTNDArray
- Check that Devices have unique names in `ensure_connected`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants