fixed bad logic introducted to test_observe
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
adjust-incorrect-sleep-in-test
branch
3 times, most recently
from
f0e0bd0 to
ba31b91
Compare
`test_observe_value_times_out_with_busy_sleep` should be using a blocking thread sleep instead of an async one.
evalott100
force-pushed
the
adjust-incorrect-sleep-in-test
branch
from
ba31b91 to
18869d0
Compare
coretl
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_observe_value_times_out_with_busy_sleepshould be using a blocking thread sleep instead of an async one.Introduced in #655.