Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional delay prop #9

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

englishtom
Copy link

The delay prop allows the user to specify an optional delay before the
scroll to top function is run. This is helpful for use cases where page
transition animations are in place.

  • Added delay prop code
  • Updated tests
  • Updated documentation

edoardo-bluframe and others added 4 commits October 13, 2018 16:48
Flow and Prettier Updates
And Flow Updates
The delay prop allows the user to specify an optional delay before the
scroll to top function is run. This is helpful for use cases where page
transition animations are in place.

- Added `delay` prop code
- Updated tests
- Updated documentation
@edoardo-bluframe
Copy link
Contributor

Hey @englishtom lovely PR!

Are you able to update to our v0.2.0 and get it ready ready to merge?

@edoardo-bluframe
Copy link
Contributor

Actually are you able to upgrade to v0.2.1?? 😄

@englishtom
Copy link
Author

Hey @edoardo-bluframe ! Sorry for the slow reply, I've been on paternity leave the last couple of weeks.

I have updated the PR to v0.2.1 as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants