Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PDS compliance #139

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Enable PDS compliance #139

merged 1 commit into from
Oct 7, 2017

Conversation

raphaelstolt
Copy link
Contributor

@raphaelstolt raphaelstolt commented Oct 7, 2017

Moved churn binary to bin/ and closes, once merged, issue #128.

@raphaelstolt raphaelstolt force-pushed the pds-compliance branch 3 times, most recently from 4b7bbb8 to 81a7a5f Compare October 7, 2017 16:57
@bmitch
Copy link
Owner

bmitch commented Oct 7, 2017

Thanks @raphaelstolt ! The Travis build is failing. I think the php churn run in the travis-ci script needs to be updated.

@raphaelstolt
Copy link
Contributor Author

raphaelstolt commented Oct 7, 2017

Fixed. Prolly would be better and DRYer to use the existing Composer scripts also for the Travis CI builds.

@raphaelstolt raphaelstolt force-pushed the pds-compliance branch 3 times, most recently from 4a93c1a to 81a7a5f Compare October 7, 2017 20:28
@codecov
Copy link

codecov bot commented Oct 7, 2017

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     67.76%   67.76%           
  Complexity      105      105           
=========================================
  Files            11       11           
  Lines           363      363           
=========================================
  Hits            246      246           
  Misses          117      117
Impacted Files Coverage Δ Complexity Δ
src/Factories/ProcessFactory.php 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d10e5...d0c4a1e. Read the comment docs.

@bmitch bmitch merged commit 60b09ed into bmitch:master Oct 7, 2017
@bmitch bmitch mentioned this pull request Oct 7, 2017
@raphaelstolt raphaelstolt deleted the pds-compliance branch October 7, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants