Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker section to README.md #147

Merged
merged 2 commits into from
Oct 12, 2017
Merged

Add Docker section to README.md #147

merged 2 commits into from
Oct 12, 2017

Conversation

tommy-muehle
Copy link
Contributor

Let me know if anything's not clear. Then I'll be happy to adjust this.

@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #147   +/-   ##
=========================================
  Coverage     67.76%   67.76%           
  Complexity      105      105           
=========================================
  Files            11       11           
  Lines           363      363           
=========================================
  Hits            246      246           
  Misses          117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1605875...47e5692. Read the comment docs.

@mglaman
Copy link

mglaman commented Oct 11, 2017

I'm having hard conflicts on bmitch/churn-php 0.3.1 requires symfony/yaml ^3.3 in global and local projects (Drupal based.) Since there is no phar this was a great workaround.

@Exadra37
Copy link

Exadra37 commented Oct 11, 2017

Correct docker command is:

docker run --rm -ti -v "$PWD":/app dockerizedphp/churn run /path/to/code

The typo is in $(PWD) that must be $PWD or $($PWD).

@bmitch
Copy link
Owner

bmitch commented Oct 11, 2017

@tommy-muehle this is very cool. If you can make the adjustment that @Exadra37 pointed out then I will go ahead and merge this. Thanks.

@tommy-muehle
Copy link
Contributor Author

@Exadra37
Thanks for the hint! I updated the command. Under macOS is also the preceding command with $(PWD) possible. So I didn't realize it.

@bmitch bmitch merged commit ade2df8 into bmitch:master Oct 12, 2017
@bmitch
Copy link
Owner

bmitch commented Oct 12, 2017

Thanks @tommy-muehle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants