-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composer scripts for windows #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage 76.08% 76.08%
Complexity 109 109
=========================================
Files 17 17
Lines 322 322
=========================================
Hits 245 245
Misses 77 77 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
composer.json
Outdated
"phpmd src text phpmd.xml", | ||
"phploc src", | ||
"phpcpd src", | ||
"phpunit --debug --coverage-clover=coverage.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands:
Note: Before executing scripts, Composer's bin-dir is temporarily pushed on top of the PATH environment variable so that binaries of dependencies are easily accessible. In this example no matter if the
phpunit
binary is actually invendor/bin/phpunit
orbin/phpunit
it will be found and executed.
Thanks @villfa - all the tests passed as far as I can see. I don't see any failing for |
@bmitch I should have specified that the tests fail only on windows. |
Ah makes sense! Perfect thank you @villfa ! |
On Windows the command
composer test
produces the following error:Removing vendor/bin/ from the commands fixes this problem.
I also noticed some namespaces were wrong in the unit tests files so I fixed them.