Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/progress bar #210

Closed
wants to merge 6 commits into from
Closed

Feature/progress bar #210

wants to merge 6 commits into from

Conversation

ilyachase
Copy link

For #199

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #210 into master will decrease coverage by 5.66%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
- Coverage     76.23%   70.57%   -5.67%     
- Complexity      109      117       +8     
============================================
  Files            17       17              
  Lines           324      350      +26     
============================================
  Hits            247      247              
- Misses           77      103      +26
Impacted Files Coverage Δ Complexity Δ
src/Renderers/Results/JsonResultsRenderer.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Collections/FileCollection.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Logic/ResultsLogic.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Results/ResultCollection.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Managers/ProcessManager.php 0% <0%> (ø) 16 <10> (+8) ⬆️
src/Commands/ChurnCommand.php 0% <0%> (ø) 6 <2> (ø) ⬇️
src/Renderers/Results/ConsoleResultsRenderer.php 0% <0%> (ø) 2 <1> (ø) ⬇️
src/Results/ResultsParser.php 100% <100%> (ø) 5 <1> (ø) ⬇️
...lomaticComplexity/CyclomaticComplexityAssessor.php 100% <100%> (ø) 14 <10> (ø) ⬇️
src/Processes/ChurnProcess.php 100% <100%> (ø) 7 <1> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309c663...56e7e11. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #210 into master will decrease coverage by 6.26%.
The diff coverage is 36.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
- Coverage     76.23%   69.97%   -6.27%     
- Complexity      109      118       +9     
============================================
  Files            17       17              
  Lines           324      353      +29     
============================================
  Hits            247      247              
- Misses           77      106      +29
Impacted Files Coverage Δ Complexity Δ
src/Renderers/Results/JsonResultsRenderer.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Collections/FileCollection.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Logic/ResultsLogic.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Results/ResultCollection.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Managers/ProcessManager.php 0% <0%> (ø) 17 <11> (+9) ⬆️
src/Commands/ChurnCommand.php 0% <0%> (ø) 6 <2> (ø) ⬇️
src/Renderers/Results/ConsoleResultsRenderer.php 0% <0%> (ø) 2 <1> (ø) ⬇️
src/Results/ResultsParser.php 100% <100%> (ø) 5 <1> (ø) ⬇️
...lomaticComplexity/CyclomaticComplexityAssessor.php 100% <100%> (ø) 14 <10> (ø) ⬇️
src/Processes/ChurnProcess.php 100% <100%> (ø) 7 <1> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309c663...3bfe548. Read the comment docs.

@gnutix
Copy link

gnutix commented Aug 20, 2020

Any reason why this is stagnant ? It would be a great feature for this lib.

@villfa
Copy link
Collaborator

villfa commented Oct 17, 2020

Thank you @ilyachase for the time you spent on this but I'm closing it since the progress bar has been added with #236.
It will be available in the next release.

@villfa villfa closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants