Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release only releases #268

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Release only releases #268

merged 2 commits into from
Nov 26, 2020

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 26, 2020

Please consider tagging releases with a v+semver as there are other kind of tags.

Please consider tagging releases with a `v` as there are other kind of tags.
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #268 (a9c3520) into master (8780627) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     96.14%   96.14%           
  Complexity      176      176           
=========================================
  Files            24       24           
  Lines           441      441           
=========================================
  Hits            424      424           
  Misses           17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8780627...a9c3520. Read the comment docs.

@villfa
Copy link
Collaborator

villfa commented Nov 26, 2020

What kind of other tags are you mentioning?

I would prefer not change the format of the tags.
Instead of v*, is there a way to define a pattern like \d+\.\d+\.\d+?

@szepeviktor
Copy link
Contributor Author

@szepeviktor
Copy link
Contributor Author

Instead of v*, is there a way to define a pattern like \d+\.\d+\.\d+?

Yes.
https://docs.github.com/en/[email protected]/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
[0-9]+.[0-9]+.[0-9]+

@villfa
Copy link
Collaborator

villfa commented Nov 26, 2020

Then if you could update your PR with this pattern I would gladly merge it.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 26, 2020

Done.

👋 good bye little v 😿

@villfa villfa merged commit 2b03172 into bmitch:master Nov 26, 2020
@villfa
Copy link
Collaborator

villfa commented Nov 26, 2020

Thanks @szepeviktor

@szepeviktor szepeviktor deleted the patch-1 branch November 26, 2020 11:01
@szepeviktor
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants