Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the ability to disable min score #298

Merged
merged 1 commit into from
Jan 31, 2021
Merged

Give the ability to disable min score #298

merged 1 commit into from
Jan 31, 2021

Conversation

villfa
Copy link
Collaborator

@villfa villfa commented Jan 31, 2021

Closes #290

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #298 (21f2b31) into master (961e415) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage     97.68%   97.69%           
  Complexity        1        1           
=========================================
  Files            29       29           
  Lines           519      521    +2     
=========================================
+ Hits            507      509    +2     
  Misses           12       12           
Impacted Files Coverage Δ Complexity Δ
src/Configuration/Config.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
src/Configuration/Validator.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961e415...21f2b31. Read the comment docs.

@villfa villfa merged commit d5a474b into bmitch:master Jan 31, 2021
@villfa villfa deleted the feat/disable-min-score branch January 31, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minScoreToShow should be nullable
1 participant