Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration maxScoreThreshold #306

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Add configuration maxScoreThreshold #306

merged 1 commit into from
Feb 15, 2021

Conversation

villfa
Copy link
Collaborator

@villfa villfa commented Feb 15, 2021

Closes #232

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #306 (6168f98) into master (369dd92) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
+ Coverage     98.92%   98.94%   +0.02%     
  Complexity        2        2              
============================================
  Files            39       40       +1     
  Lines           742      759      +17     
============================================
+ Hits            734      751      +17     
  Misses            8        8              
Impacted Files Coverage Δ Complexity Δ
src/Command/Helper/MaxScoreChecker.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Command/RunCommand.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
src/Configuration/Config.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
src/Configuration/Validator.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
src/Event/HookLoader.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369dd92...6168f98. Read the comment docs.

@villfa villfa merged commit 0c3679e into bmitch:master Feb 15, 2021
@villfa villfa deleted the feat/threshold branch February 15, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make command fail if score is higher than a configurable threshold
1 participant