Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of functions returning false #320

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

villfa
Copy link
Collaborator

@villfa villfa commented Dec 14, 2021

This fixes errors returned by Psalm when run with PHP 8.1.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #320 (fcb6f3e) into master (53846ae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #320      +/-   ##
============================================
+ Coverage     99.12%   99.14%   +0.01%     
  Complexity        2        2              
============================================
  Files            40       40              
  Lines           801      818      +17     
============================================
+ Hits            794      811      +17     
  Misses            7        7              
Impacted Files Coverage Δ
src/Configuration/Loader.php 100.00% <100.00%> (ø)
src/Process/ConcreteProcessFactory.php 96.42% <100.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53846ae...fcb6f3e. Read the comment docs.

@villfa villfa merged commit c9ead12 into bmitch:master Dec 14, 2021
@villfa villfa deleted the fix/false branch December 14, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant