Added container name to create container command. #44
Conversation
|
Thanks for your pull request. Would you mind adding an integration test as well? Please have a look at DockerWorkflowIntegrationTest.groovy. |
|
Sure, didn't spot that test before. Thanks for the pointer! Will update my pull request. Is there a specific local docker setup required. The workflow tests seem to be skipped on my ubuntu based machine with a docker daemon running. |
|
I have added your requested integration test. Actually I enhanced your |
| @@ -60,4 +60,8 @@ repositories { | |||
| protected String createUniqueImageId() { | |||
| "gradle/${UUID.randomUUID().toString().replaceAll('-', '')}" | |||
| } | |||
|
|
|||
| protected String createUniqueContainerName() { | |||
There was a problem hiding this comment.
Instead of adding a new method I think we should simply rename the existing method createUniqueImageId to something else. Probably just createUniqueId.
There was a problem hiding this comment.
Sure, I will refactor that. Didn't want to interfere too much with the other test code.
There was a problem hiding this comment.
Finally I realized that a container name may not contain a '/' like the image id. So I have kept the 2 methods.
|
You can now adapt to your Docker setup (see FAQ for more information). To be able to execute the test, you'll have to make sure that the Docker server URL is resolvable. |
|
I had to add a DockerInspectContainer task type in order to facilitate testing. However I was wondering of what use those Inspect tasks are as they are just logging some image/container attributes. How about exposing the full inspect response to the task client? Generally speaking I think a inspect task will be useful for querying any image/container attribute. |
|
Thanks for the pull request. It has been merged. |
|
Thanks for supporting, expect a new pull-request for container linking soon. |
Next, I will start adding container linking as suggested in issue #42