Update dependencies and pin elasticsearch version to <8 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old whitelist_externals setting was deprecated for a long time and got removed in the meantime [1]. [1]: tox-dev/tox#2600
felixedel
force-pushed
the
fe-update-dependencies
branch
from
ed0764d to
20f5d96
Compare
The update to v8 comes with a lot of API changes which should be implemented and tested in a dedicated change. To allow updating the other dependencies, let's pin the elasticsearch and elasticsearch-dsl packages for now.
felixedel
force-pushed
the
fe-update-dependencies
branch
from
20f5d96 to
2f088b3
Compare
westphahl
previously approved these changes
Jan 5, 2024
The rendered output changed with the newer sphinx version, so we have to adapt the test cases.
The new Sphinx version broke our Zubbi directive implementation. The reason is that the Sphinx log output changed and thus our custom directives cannot parse the output properly anymore. We use the Sphinx log to write (and later extract) the custom data from our directives. This never felt like an appropriate solution but most propably it was the easiest to do and we didn't find a better solution. This change improves the Zubbi directives by storing the data in Sphinx' domaindata dictionary which seems to be more appropriate for this use case. This is also what other directives (including the "native" Sphinx directives) do for storing and extracting data).
The newer version of the elasticsearch library changed the underlying API, which makes our test cases fail. Adapt them accordingly.
felixedel
force-pushed
the
fe-update-dependencies
branch
from
431a34e to
010a0a1
Compare
westphahl
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to v8 comes with a lot of API changes which should be
implemented and tested in a dedicated change. To allow updating the other
dependencies, let's pin the elasticsearch and elasticsearch-dsl packages
for now.