-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add commit message lint #1044
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
const maxTypeNumber = 3 | ||
|
||
const validateTypeNums = (parsedCommit) => { | ||
if (!parsedCommit.type) { | ||
return [false, 'invalid commit message'] | ||
} | ||
|
||
return [ | ||
parsedCommit.type.split(' ').length <= maxTypeNumber, | ||
`type must not be more than ${maxTypeNumber}`, | ||
] | ||
} | ||
|
||
|
||
module.exports = { | ||
parserPreset: { | ||
parserOpts: { | ||
headerPattern: /^(.*): .*/, | ||
} | ||
}, | ||
extends: ['@commitlint/config-conventional'], | ||
plugins: ['commitlint-plugin-function-rules'], | ||
rules: { | ||
'subject-empty':[2, 'always'], | ||
'scope-empty':[2, 'always'], | ||
'type-enum': [2, 'never'], | ||
'function-rules/type-case': [2, 'always', validateTypeNums], | ||
'type-max-length': [2, 'always', 20], | ||
'header-max-length': [ | ||
2, | ||
'always', | ||
72, | ||
], | ||
}, | ||
helpUrl: | ||
'https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md', | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Lint Commit Messages | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
- develop | ||
|
||
pull_request: | ||
branches: | ||
- master | ||
- develop | ||
|
||
jobs: | ||
commitlint: | ||
strategy: | ||
matrix: | ||
node-version: [14.x] | ||
os: [ubuntu-18.04] | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- uses: actions/cache@v3 | ||
with: | ||
path: | | ||
~/.npm | ||
**/node_modules | ||
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-node- | ||
- name: Install Deps | ||
run: | | ||
npm install -g commitlint-plugin-function-rules @commitlint/cli | ||
npm install --save-dev commitlint-plugin-function-rules @commitlint/cli | ||
- uses: wagoid/commitlint-github-action@v5 | ||
id: commitlint | ||
env: | ||
NODE_PATH: ${{ github.workspace }}/node_modules | ||
with: | ||
configFile: /github/workspace/.github/commitlint.config.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
## Commit Format Requirements | ||
1. The head line should contain no more than 72 characters | ||
2. head line is composed by scope : subject | ||
3. multi-scope is supported, separated by a space, such as scope1 scope2 scope3: subject | ||
it is better that scope number =<3 , scope length <= 20 char , but not mandatory | ||
4. keyword, such as R4R or WIP is not acceptable in the scope, no matter upper case or lower case. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This rule is not checked? r4r or wip is not acceptable in scope. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added, please check |
||
|
||
#### Example: Single Scope | ||
``` | ||
evm: optimize opcode mload | ||
``` | ||
|
||
#### Example: Multi Scope | ||
``` | ||
rpc core db: refactor the interface of trie access | ||
``` | ||
|
||
#### Example: Big Scope | ||
if the change is too big, impact several scopes, the scope name can be bep, feat or fix | ||
``` | ||
bep130: implement parallel evm | ||
|
||
feat: implement parallel trie prefetch | ||
|
||
fix: stack overflow on GetCommitState | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maxTypeNumber
is not mandatory right now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed