Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add commit message lint #1044

Merged
merged 2 commits into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/commitlint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
const maxTypeNumber = 3

const validateTypeNums = (parsedCommit) => {
if (!parsedCommit.type) {
return [false, 'invalid commit message']
}

return [
parsedCommit.type.split(' ').length <= maxTypeNumber,
`type must not be more than ${maxTypeNumber}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxTypeNumber is not mandatory right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

]
}


module.exports = {
parserPreset: {
parserOpts: {
headerPattern: /^(.*): .*/,
}
},
extends: ['@commitlint/config-conventional'],
plugins: ['commitlint-plugin-function-rules'],
rules: {
'subject-empty':[2, 'always'],
'scope-empty':[2, 'always'],
'type-enum': [2, 'never'],
'function-rules/type-case': [2, 'always', validateTypeNums],
'type-max-length': [2, 'always', 20],
'header-max-length': [
2,
'always',
72,
],
},
helpUrl:
'https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md',
}
45 changes: 45 additions & 0 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Lint Commit Messages

on:
push:
branches:
- master
- develop

pull_request:
branches:
- master
- develop

jobs:
commitlint:
strategy:
matrix:
node-version: [14.x]
os: [ubuntu-18.04]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- uses: actions/cache@v3
with:
path: |
~/.npm
**/node_modules
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- name: Install Deps
run: |
npm install -g commitlint-plugin-function-rules @commitlint/cli
npm install --save-dev commitlint-plugin-function-rules @commitlint/cli
- uses: wagoid/commitlint-github-action@v5
id: commitlint
env:
NODE_PATH: ${{ github.workspace }}/node_modules
with:
configFile: /github/workspace/.github/commitlint.config.js
26 changes: 26 additions & 0 deletions docs/lint/commit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
## Commit Format Requirements
1. The head line should contain no more than 72 characters
2. head line is composed by scope : subject
3. multi-scope is supported, separated by a space, such as scope1 scope2 scope3: subject
it is better that scope number =<3 , scope length <= 20 char , but not mandatory
4. keyword, such as R4R or WIP is not acceptable in the scope, no matter upper case or lower case.
Copy link
Collaborator

@brilliant-lx brilliant-lx Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is not checked? r4r or wip is not acceptable in scope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, please check


#### Example: Single Scope
```
evm: optimize opcode mload
```

#### Example: Multi Scope
```
rpc core db: refactor the interface of trie access
```

#### Example: Big Scope
if the change is too big, impact several scopes, the scope name can be bep, feat or fix
```
bep130: implement parallel evm

feat: implement parallel trie prefetch

fix: stack overflow on GetCommitState
```