worker: enhancement of the current block generation logic. #1186

setunapo · 2022-11-17T04:18:02Z

Description

Currently, validator only try once to get transactions from TxPool to produce the block.
However, new transactions could arrive while the validator is committing transaction.
Validator should be allowed to add these new arrived transactions as long as Header.Timestamp is not reached.

Rationale

This PR will:

commitTransactions return with error code.
drop current mining block on new block imported or resubmit timer(default 10s) is triggered.
try fillTransactions several times for the best, not use append mode to follow the GasPrice rule.
an algorithm to determine new fillTransactions, based on: the number of new arrived transaction, the time left, the previous cost of fillTransactions, to avoid do fillTransactions too frequently.

And the general workflow of new implementation could be described as:

Example

NA.

Changes

It could effect the mining logic, validators will be update to align the mine logic.

Currently, validator only try once to get transactions from TxPool to produce the block. However, new transactions could arrive while the validator is committing transaction. Validator should be allowed to add these new arrived transactions as long as Header.Timestamp is not reached This commit will: ** commitTransactions return with error code ** drop current mining block on new block imported ** try fillTransactions several times for the best not use append mode to follow the GasPrice rule. ** check if there is enough time for another fillTransactions.

qinglin89 · 2022-11-17T07:48:58Z

miner/worker.go

 			return
 		}
 	}
 	if len(remoteTxs) > 0 {
 		txs := types.NewTransactionsByPriceAndNonce(env.signer, remoteTxs, env.header.BaseFee)
-		if w.commitTransactions(env, txs, interruptCh, stopTimer) {
+		err = w.commitTransactions(env, txs, interruptCh, stopTimer)
+		if err == errBlockInterruptedByNewHead || err == errBlockInterruptedByOutOfGas || err == errBlockInterruptedByTimeout {


this if seems useless here, would return anyway

It may not efficient if schedule fillTransactions when new transactions arrive. It could make the CPU keep running. To make is more efficient: 1.schedule fillTransactions when a certain amount of transaction are arrived. 2.or there is not much time left.

miner/worker.go

When new block is imported, there is no need to commit the current work, even the new imported block is offturn and itself is inturn. That is because when offturn block is received, the inturn block is already later to broadcast block, deliver the later block will cause many reorg, which is not reasonable. And also make sure all useless work can be discarded, to avoid goroutine leak.

it is not necssary to add more transaction when resubmit is fired. the resubmit logic was for PoW and can be removed later.

setunapo changed the title ~~worker: some block produce enhancement of work.go~~ worker: enhancement of the current block generation logic. Nov 17, 2022

setunapo force-pushed the worker_develop branch from abdc7c6 to 6c017c4 Compare November 17, 2022 04:26

brilliant-lx requested review from j75689, kyrie-yl, unclezoro, keefel, qinglin89 and yutianwu November 17, 2022 04:36

brilliant-lx added the r4r ready for review label Nov 17, 2022

setunapo force-pushed the worker_develop branch from 6c017c4 to 5c88f9f Compare November 17, 2022 04:45

qinglin89 reviewed Nov 17, 2022

View reviewed changes

setunapo force-pushed the worker_develop branch from 05ad34f to dad8b3f Compare November 17, 2022 08:05