R4R: system contract upgrade framework and upgrade tokenhub

[HaoyangLiu]

No description provided.

[unclezoro]

can not just simple define devnetUpgrapdeConfig[20000] here. Because 20000 is treat as fork height here, we must define the fork height on chainConfig, like dao fork get DAOForkBlock in config. Otherwise will break the handshake protocol about forkId.

[unclezoro]

We need define a map like map[forkname] []*UpgradeConfig here. Then define different height for the fork for different network on Params file

[unclezoro]

we have redefined the system contract address here, since parlia have done it too. But I don't know where to put it better either. Just a bit uncomfortable for this.

[HaoyangLiu]

System addresses in parlia.go are not completed. Besides, I think it would be better to defind all addresses in here ranther than in consensus engine.

[unclezoro]

if no match with any network, just return

[HaoyangLiu]

In the further development, we might need to start a local network. This local network might also need system upgrade, so I added a default network type.

[unclezoro]

==> logger.Info("Upgrade contract to commit ", "address", cfg.ContractAddr.String(),"commit url", cfg.CommitUrl)

[HaoyangLiu]

commit url contains space. Besides, I think no need to follow this style. In many case, logger.Info is used together with fmt.Sprintf.

[unclezoro]

The log style here violate how the log being used.

[unclezoro]

there is no need to define type beforeUpgrade and afterUpgrade, upgradeHook is enough.

[unclezoro]

please add return (error) to this hook.

[HaoyangLiu]

there is no need to define type beforeUpgrade and afterUpgrade, upgradeHook is enough.

I don't think upgradeHook is enough. Sometime we have to do cleanup work before update code, and sometime we have to do init work after update code

[HaoyangLiu]

Sorry for misunderstand. We can just define one function typeupgradeHook but multiple instances

type UpgradeConfig struct {
	BeforeUpgrade ugradeHook
	AfterUpgrade  ugradeHook
        ...
}