txpool: apply miner's gasceil to txpool #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply `Eth.Miner.GasCeil` to TxPool even the node did not enable `--mine` option Otherwise, there could be accmulated pending transactions in txpool. Take an example: - Currently, BSC testnet's block gaslimit is 70M, as 20M gas is reserved for SystemTxs, the maximum acceptable GasLimit for transaction is 50M. - TxPool recevied a transaction with GasLimit 60M, it would be accepted in TxPool but it will never be accepted by validators. Such kinds of transactions will be kept in txpool and gradually make the txpool overflowed
zzzckck
force-pushed
the
txpool_gasceil
branch
from
d92545a to
63f4c0e
Compare
galaio
approved these changes
Sep 4, 2024
zzzckck
added a commit
to zzzckck/bsc
that referenced
this pull request
Sep 5, 2024
This PR tries to improve bnb-chain#2680 If the node did not set `Eth.Miner` in config.toml, the default GasCeil will be 30000000, it is not an accurate number for both BSC mainnet and testnet. Set it to 0 means disable the transaction GasLimit check, i.e. the TxPool will accept transactions with any GasLimit size.
zzzckck
added a commit
that referenced
this pull request
Sep 5, 2024
This PR tries to improve #2680 If the node did not set `Eth.Miner` in config.toml, the default GasCeil will be 30000000, it is not an accurate number for both BSC mainnet and testnet. Set it to 0 means disable the transaction GasLimit check, i.e. the TxPool will accept transactions with any GasLimit size.
This was referenced Sep 12, 2024
Merged
Magkoooh
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply
Eth.Miner.GasCeilto TxPool even the node did not enable--mineoption. Otherwise, there could be accmulated pending transactions in txpool.Take an example:
SystemTxs, the maximum acceptable GasLimit for transaction is 50M.
will never be accepted by validators. Such kinds of transactions will be kept in txpool
and gradually make the txpool overflowed
Here is part of the TxPool status dumped from one mainnet p2p node(current mainnet block gaslimit 140M): transactions with GasLimit(133000000) will always in pending state and it also blocks its following transactions
Rationale
NA
Example
NA
Changes
Pls check your config.toml:
Eth.Miner.GasCeil, make sure it is correct, for current mainnet it is140000000Eth.Miner.GasCeil, it is ok, but you may face the issue mentioned in this PR, your TxPool could be full.To clarify how GasCeil will be calculated: