Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEP-466: Make the block header format compatible with EIP-7685 #2777

Merged
merged 1 commit into from
Dec 13, 2024
Merged

BEP-466: Make the block header format compatible with EIP-7685 #2777

merged 1 commit into from
Dec 13, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Nov 28, 2024 •
edited
Loading

Description

BEP-466: Make the block header format compatible with EIP-7685

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0
Copy link
Collaborator Author

buddh0 commented Nov 28, 2024 •
edited
Loading

RequestsHash should also be used to generate the signature of blocks,
refer https://github.com/bnb-chain/bsc/blob/develop/core/types/block.go#L766

@buddh0 buddh0 force-pushed the bep-446 branch 2 times, most recently from a06734d to 9185f29 Compare November 28, 2024 08:21
@buddh0 buddh0 marked this pull request as ready for review November 28, 2024 08:49
MatusKysel
MatusKysel reviewed Nov 28, 2024
View reviewed changes
core/chain_makers.go Outdated Show resolved Hide resolved
MatusKysel
MatusKysel previously approved these changes Nov 28, 2024
View reviewed changes
@buddh0 buddh0 marked this pull request as draft November 28, 2024 11:08
@yoshidan yoshidan mentioned this pull request Dec 1, 2024
Open
zzzckck
zzzckck previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far, LGTM, but need further update as Ethereum will remove requests from block body, BSC will do the same thing.

MatusKysel
MatusKysel previously approved these changes Dec 2, 2024
View reviewed changes
@buddh0 buddh0 dismissed stale reviews from MatusKysel and zzzckck via f1892d8 December 10, 2024 09:49
@buddh0 buddh0 force-pushed the bep-446 branch 3 times, most recently from ed25018 to 596a027 Compare December 10, 2024 10:10
@buddh0 buddh0 changed the title BEP-466: Make the block format compatible with EIP-7685 BEP-466: Make the block header format compatible with EIP-7685 Dec 13, 2024
@buddh0 buddh0 marked this pull request as ready for review December 13, 2024 07:34
MatusKysel
MatusKysel approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@MatusKysel MatusKysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zzzckck zzzckck merged commit 0ad0e9f into bnb-chain:develop Dec 13, 2024
6 of 7 checks passed
This was referenced Dec 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@setunapo setunapo setunapo approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@buddh0 @MatusKysel @setunapo @zzzckck