Support for transferring ownership #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fletcher142
commented
Jan 12, 2021
fletcher142
commented
- support for transferring ownership
- change the symbol length validation
unclezoro
reviewed
Jan 14, 2021
client/rpc/dex_client.go
Outdated
| if c.key == nil { | ||
| return nil, KeyMissingError | ||
| } | ||
| if symbol == "" { |
There was a problem hiding this comment.
no need to do check here. Basic check will be done inside Broadcast .
unclezoro
reviewed
Jan 14, 2021
| return nil, fmt.Errorf("Transfer token ownership, symbol can't be empty ") | ||
| } | ||
| if newOwner == nil { | ||
| return nil, fmt.Errorf("Transfer token ownership, new owner can't be nil ") |
rickyyangz
previously approved these changes
Jan 14, 2021
unclezoro
approved these changes
Jan 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.