[R4R]api: expose memo and source

[unclezoro]

No description provided.

[ackratos]

the change looks good. But better to have backward compatibility by adding GetMemo() and GetSource() methods to Msg interface and add a common base type i.e. Metadata to each msg types hold memo and source. Then we can pass in each create message function an vararg type MetadataSetter = func(Msg) Msg i.e.

func (c *client) MintToken(symbol string, amount int64, sync bool, MetadataSetter...) (*MintTokenResult, error) {

then user can inject memo and source on demand. And in broadcastMsg just call GetSource and GetMemo on Msg interface to get corresponding fields.

[unclezoro]

the change looks good. But better to have backward compatibility by adding GetMemo() and GetSource() methods to Msg interface and add a common base type i.e. Metadata to each msg types hold memo and source. Then we can pass in each create message function an vararg type MetadataSetter = func(Msg) Msg i.e.

func (c *client) MintToken(symbol string, amount int64, sync bool, MetadataSetter...) (*MintTokenResult, error) {

then user can inject memo and source on demand. And in broadcastMsg just call GetSource and GetMemo on Msg interface to get corresponding fields.

You are right. Have changed into what you expected. Please check latest commit.