Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timelock queries #71

Merged
merged 7 commits into from
Aug 2, 2019
Merged

add timelock queries #71

merged 7 commits into from
Aug 2, 2019

Conversation

chainwhisper
Copy link
Contributor

No description provided.

yutianwu
yutianwu reviewed Aug 2, 2019
View reviewed changes
common/types/timelock.go Outdated Show resolved Hide resolved
yutianwu
yutianwu reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated Show resolved Hide resolved
yutianwu
yutianwu reviewed Aug 2, 2019
View reviewed changes
e2e/e2e_rpc_test.go Outdated Show resolved Hide resolved
yutianwu
yutianwu reviewed Aug 2, 2019
View reviewed changes
common/types/timelock.go Outdated Show resolved Hide resolved
yutianwu
yutianwu reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated
@@ -5,12 +5,17 @@ import (
"fmt"
"github.com/binance-chain/go-sdk/common/types"
"github.com/binance-chain/go-sdk/types/tx"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this empty line

unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
common/types/timelock.go Outdated Show resolved Hide resolved
@unclezoro
Copy link
Contributor

unclezoro commented Aug 2, 2019 •
edited
Loading

Can you add these two new method into the interface type DexClient interface

unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated
@@ -11,6 +11,9 @@ const (
AccountStoreName = "acc"
TokenStoreName = "tokens"
ParamABCIPrefix = "param"
TimeLockMsgRoute = "timelock"
QueryTimeLocks = "timelocks"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the code style consistent, QueryTimeLocks and QueryTimeLock please just use it, don't define the constant.

unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 2, 2019
View reviewed changes
client/rpc/dex_client.go Outdated Show resolved Hide resolved
unclezoro
unclezoro previously approved these changes Aug 2, 2019
View reviewed changes
@chainwhisper chainwhisper merged commit eb7b0b0 into master Aug 2, 2019
@unclezoro unclezoro deleted the add-timlock branch April 20, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutianwu yutianwu yutianwu left review comments

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chainwhisper @unclezoro @yutianwu