[R4R]uprade to tendermint release 0.32.3 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
force-pushed
the
tendermint0.32.3
branch
3 times, most recently
from
f3ddeb3 to
eab6c53
Compare
unclezoro
changed the title
unclezoro
force-pushed
the
tendermint0.32.3
branch
3 times, most recently
from
a3b8be1 to
69eca9f
Compare
unclezoro
force-pushed
the
tendermint0.32.3
branch
from
69eca9f to
3d3a7e2
Compare
HaoyangLiu
reviewed
Nov 6, 2019
HaoyangLiu
reviewed
Nov 6, 2019
HaoyangLiu
reviewed
Nov 6, 2019
| GasWanted int64 `json:"gas_wanted,omitempty"` | ||
| GasUsed int64 `json:"gas_used,omitempty"` | ||
| Events []types.Event `json:"events,omitempty"` | ||
| Tags []cmn.KVPair `json:"tags,omitempty"` |
There was a problem hiding this comment.
Why there are both Events and Tags?
HaoyangLiu
previously approved these changes
Nov 6, 2019
|
Need to add those in CHANGELOG |
HaoyangLiu
previously approved these changes
Nov 11, 2019
yutianwu
reviewed
Nov 11, 2019
| @@ -23,13 +23,13 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| nodeAddr = "tcp://127.0.0.1:80" | |||
| nodeAddr = "tcp://data-seed-pre-0-s3.binance.org:80" | |||
There was a problem hiding this comment.
should we change node address to testnet node
unclezoro
force-pushed
the
tendermint0.32.3
branch
from
4e00164 to
d295222
Compare
HaoyangLiu
previously approved these changes
Nov 11, 2019
unclezoro
force-pushed
the
tendermint0.32.3
branch
from
d295222 to
d96333a
Compare
unclezoro
force-pushed
the
tendermint0.32.3
branch
from
d96333a to
f8e5b29
Compare
yutianwu
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.