fix: txpool concurrent map issue #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanxyg
approved these changes
Jan 13, 2025
bnoieh
approved these changes
Jan 13, 2025
owen-reorg
changed the title
will-2012
pushed a commit
to will-2012/op-geth
that referenced
this pull request
Feb 6, 2025
…-registry Remove hardfork activation time overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for fixing the issue of concurrent map reading and writing on the map of txpool.queue.
It was introduced by PR #247 , in which the numbers of pending and queued transactions were added to logs.
The txpool.queue and txpool.pending should always be protected by the mu lock of txpool, So we use Stats() instead of stats();
Besides, there is no need to iterator the pending and queue lists to sum the total numbers. The variables pendingCounter and queueCounter records them.