-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal: Build out Time
and its methods
#3613
Conversation
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3613 +/- ##
==========================================
+ Coverage 47.44% 47.59% +0.15%
==========================================
Files 475 475
Lines 46036 46138 +102
==========================================
+ Hits 21841 21960 +119
+ Misses 24195 24178 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
This Pull Request is related to the ongoing work on #1804. Mostly the work here is around building out more of the
Time
component and it's methods.It changes the following:
Duration
'sis_date_duration
andis_time_duration
methods (exposes them as public too)Time
componentAdd
,Subtract
, andRound
methods along with implementation details