Temporal: `DateTime` and `PlainDateTime` functionality #3628

nekevss · 2024-01-30T01:54:03Z

This Pull Request is related to the ongoing work for #1804.

It changes the following:

Builds out some basic accessor functionality on boa_temporal's DateTime.
Implements PlainDateTime's accessor properties, accounting for the above changes.

codecov · 2024-01-30T02:03:31Z

Codecov Report

Attention: 240 lines in your changes are missing coverage. Please review.

Comparison is base (34d0084) 47.43% compared to head (1533e62) 47.43%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
...ngine/src/builtins/temporal/plain_date_time/mod.rs	45.70%	139 Missing ⚠️
core/temporal/src/components/datetime.rs	16.49%	81 Missing ⚠️
core/temporal/src/components/date.rs	0.00%	7 Missing ⚠️
core/temporal/src/components/zoneddatetime.rs	0.00%	6 Missing ⚠️
...re/engine/src/builtins/temporal/calendar/object.rs	0.00%	4 Missing ⚠️
core/temporal/src/iso.rs	89.65%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3628      +/-   ##
==========================================
- Coverage   47.43%   47.43%   -0.01%     
==========================================
  Files         476      476              
  Lines       46288    46578     +290     
==========================================
+ Hits        21959    22094     +135     
- Misses      24329    24484     +155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-30T02:12:24Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	95,960	95,960	0
Passed	79,714	79,920	+206
Ignored	3,897	3,897	0
Failed	12,349	12,143	-206
Panics	0	0	0
Conformance	83.07%	83.28%	+0.21%

Fixed tests (220):

test/built-ins/Temporal/PlainDateTime/order-of-operations.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/subclass.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/subclass.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/missing-arguments.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/missing-arguments.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/infinity-throws-rangeerror.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/calendar-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/calendar-undefined.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/calendar-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/constructor.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/negative-infinity-throws-rangeerror.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-object-insufficient-data.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-object-insufficient-data.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/argument-not-object.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-throws.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-throws.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/options-invalid.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-merge-fields-returns-primitive.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-merge-fields-returns-primitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/string-throws.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/string-throws.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/timezone-throws.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/timezone-throws.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/options-invalid.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-singular-properties.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-singular-properties.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-invalid-property.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-invalid-property.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-invalid.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/year/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/year/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/year/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/year/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/year/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/year/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/microsecond/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/microsecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/microsecond/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/microsecond/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/validate-calendar-value.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/validate-calendar-value.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/inLeapYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toString/smallestunit-plurals-accepted.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toString/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/day/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/day/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/day/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/day/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/day/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/day/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/options-invalid.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-singular-properties.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-singular-properties.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-invalid-property.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-invalid-property.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/options-invalid.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/second/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/second/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/second/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/second/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/nanosecond/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/nanosecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/nanosecond/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/nanosecond/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toLocaleString/return-string.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toLocaleString/return-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/basic.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/hour/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/hour/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/hour/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/hour/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/minute/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/minute/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/minute/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/minute/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/calendarId/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/calendarId/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/calendarId/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/calendarId/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/validate-calendar-value.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/validate-calendar-value.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/monthCode/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/yearOfWeek/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/millisecond/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/millisecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/millisecond/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/millisecond/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-number.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-object-insufficient-data.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-object-insufficient-data.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-undefined.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/options-wrong-type.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-no-argument.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-no-argument.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/month/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/month/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/month/builtin-calendar-no-observable-calls.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/month/builtin-calendar-no-observable-calls.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/month/branding.js [strict mode] (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/month/branding.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInWeek/date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInWeek/date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/year/date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/year/date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/day/date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/day/date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dayOfYear/plain-date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dayOfYear/plain-date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInYear/plain-date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/daysInYear/plain-date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/monthCode/date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/monthCode/date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dayOfWeek/plain-date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dayOfWeek/plain-date-time.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/month/date-time.js [strict mode] (previously Failed)
test/built-ins/Temporal/Calendar/prototype/month/date-time.js (previously Failed)

Broken tests (14):

test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-year-zero.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-year-zero.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/duplicate-calendar-fields.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/duplicate-calendar-fields.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-critical-unknown-annotation.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-critical-unknown-annotation.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-multiple-time-zone.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-multiple-time-zone.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/constructor-in-calendar-fields.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/constructor-in-calendar-fields.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/proto-in-calendar-fields.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/proto-in-calendar-fields.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-multiple-calendar.js [strict mode] (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-multiple-calendar.js (previously Passed)

nekevss · 2024-01-30T14:23:23Z

All of the broken tests were previously false positives from returning a RangeError when the PlainDateTime constructor was called.

raskad

Nice work

jasonwilliams

LGTM

Build out Temporal DateTime functionality

8951d92

nekevss force-pushed the temporal-dt-pdt-builtin branch from 1de809d to 9f59e52 Compare January 30, 2024 04:53

Fix limit.js test and add datetime limit test

846d49c

nekevss force-pushed the temporal-dt-pdt-builtin branch from 9f59e52 to 846d49c Compare January 30, 2024 04:55

clippy and fmt

1533e62

nekevss requested a review from a team January 30, 2024 14:19

nekevss added builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 30, 2024

raskad approved these changes Jan 30, 2024

View reviewed changes

raskad requested a review from a team January 30, 2024 17:11

jasonwilliams approved these changes Jan 30, 2024

View reviewed changes

raskad added this pull request to the merge queue Jan 30, 2024

Merged via the queue into main with commit 39ba999 Jan 30, 2024
14 checks passed

jedel1043 deleted the temporal-dt-pdt-builtin branch January 30, 2024 23:29

HalidOdat mentioned this pull request Feb 28, 2024

initial changelog for v0.18 #3691

Merged

jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporal: `DateTime` and `PlainDateTime` functionality #3628

Temporal: `DateTime` and `PlainDateTime` functionality #3628

nekevss commented Jan 30, 2024

codecov bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024 •

edited

Loading

nekevss commented Jan 30, 2024

raskad left a comment

jasonwilliams left a comment

Temporal: DateTime and PlainDateTime functionality #3628

Temporal: DateTime and PlainDateTime functionality #3628

Conversation

nekevss commented Jan 30, 2024

codecov bot commented Jan 30, 2024 • edited Loading

Codecov Report

github-actions bot commented Jan 30, 2024 • edited Loading

Test262 conformance changes

nekevss commented Jan 30, 2024

raskad left a comment

Choose a reason for hiding this comment

jasonwilliams left a comment

Choose a reason for hiding this comment

Temporal: `DateTime` and `PlainDateTime` functionality #3628

Temporal: `DateTime` and `PlainDateTime` functionality #3628

codecov bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024 •

edited

Loading