Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move methods of JsString to JsStr #4106

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Move methods of JsString to JsStr #4106

merged 1 commit into from
Jan 7, 2025

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jan 4, 2025 •
edited
Loading

This just moves some methods from JsString to JsStr, since they're more general and should be useful when you have only a JsStr.
Also changes the debug implementation of JsStr to only print the underlying string.

@jedel1043 jedel1043 added enhancement New feature or request API labels Jan 4, 2025
@jedel1043 jedel1043 added this to the next-release milestone Jan 4, 2025
@jedel1043 jedel1043 requested a review from a team January 4, 2025 05:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 43,947 43,947 0
Ignored 3,096 3,096 0
Failed 3,211 3,211 0
Panics 0 0 0
Conformance 87.45% 87.45% 0.00%

@raskad raskad requested a review from a team January 5, 2025 23:24
@jedel1043 jedel1043 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 579c455 Jan 7, 2025
13 checks passed
@jedel1043 jedel1043 deleted the refactor-jsstr branch January 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@hansl hansl hansl approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @hansl @raskad